This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add newPrivateTab #8074
Merged
Add newPrivateTab #8074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Auditors: @bsclifton, @bbondy - Close #7934
cezaraugusto
requested review from
bsclifton,
bbondy,
NejcZdovc,
jamesmudgett and
bradleyrichter
bsclifton
reviewed
Apr 7, 2017
There was a problem hiding this comment.
Works great! @bradleyrichter may have an update for the text, but I'll merge for now 😄
cezaraugusto
added a commit
that referenced
this pull request
May 16, 2017
- This landed in #8074 but somehow regressed - Fix #8895 Auditors: @bradleyrichter Test Plan: new private tab paragraphs should be properly spaced
bsclifton
pushed a commit
that referenced
this pull request
May 17, 2017
- This landed in #8074 but somehow regressed - Fix #8895 Auditors: @bradleyrichter Test Plan: new private tab paragraphs should be properly spaced
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated test plan
Test plan
Below screenshot should show by any means when opening a new private tab (NOTE: copy may be updated in a later issue)
Description
git rebase -ito squash commits (if needed).Auditors: @bsclifton, @bbondy
Close #7934